Fixed Internally Direct Damage Twincast Tag Bugged

Discussion in 'Resolved' started by Sancus, Oct 27, 2019.

  1. Sancus Augur

    Summary: It appears that direct damage hits from procs are getting flagged as Twincasts without actually being twincasts. This causes the Direct Damage log message for Twincasts to report Twincast rates inaccurately. As a brief example, Dragonmagic Spell (49358) is reporting that it is Twincasting, despite being unable to.
    ____________________________________________

    I first noticed this with Dragonmagic Spell (49358). It is flagged as unfocusable, and therefore should be unable to Twincast. However in a given raid night, I saw over a thousand instances of it supposedly Twincasting.

    I then ran a controlled test on a combat dummy, and found there were numerous instances of it reporting that it Twincasted despite only getting one proc in a given second (meaning it was not actually Twincast):

    [IMG]

    Furthermore, from previous testing we know that the formula for procs using SPA 383 with a Base1 = 100 on a spell with a Cast Time between 2.5 and 7 seconds is (Cast_Time - 1) * 0.167. I used Spear of Blistersteel, Spear of Molten Shieldstone, and Spear of Molten Arcronite (all 3.5s cast time), so the proc rate on each spell should have been 41.75%. I was running Twincast Rk. III, so all of my spells Twincast and I had 7,534 total hits with spells. This would imply 3,145 procs of Dragonmagic Spell and 3,775 procs of other procs that are able to Twinproc (3,145 * 1.2).

    Despite having a wide range of reported # of Twincasts between my various procs, they all followed this formula. Dragonmagic had 3175 procs and my other procs (all of which can twinproc 20% of the time) ranged from 3,720 procs to 3,812, all very close to 3,775:

    [IMG]

    You'll notice in the above the reported # of twincasts varies wildly over procs that should have approximately the same number of Twincasts (~629), despite them still having about the same # of overall hits. Dragonmagic cannot Twincast, and yet is reporting that it is Twincasting. Therefore, it seems very likely that Twincasts are not reporting accurately.
    Tacoheals, Winnowyl, Beimeith and 3 others like this.
  2. kizant Augur

    I did some checking on Test and verified that this seems to happen solely based on having twinproc. If I don't have twincast AAs or twincast of any kind. Then I noticed something in the logs that gives a hint at what could be doing it. Look at these groups of log entries. I started from the newest and worked my way up and this was consistent 8 times in a row. So, I don't think it's just a coincidence.

    Notice how as soon as one real twinproc happens that every single proc that happens afterwards also receives a Twincast tag at the end of the log entry? Like the state gets stuck or is never reset so it thinks everything aferward is a twincast even when it isn't.

    Example #1
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 143207 points of fire damage by Ethereal Skyfire Rk. III.
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three's body is consumed in ethereal flames.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 450 points of cold damage by Freezing Strike VI.
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three shudders.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 9785 points of cold damage by Burst of Ice X. (Lucky Critical)
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three is struck by ice.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 2798 points of corruption damage by Spike of Corruption.
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three is struck by corruption.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 2798 points of corruption damage by Spike of Corruption. (Twincast)
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three is struck by corruption.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 1583 points of corruption damage by Force of Corruption X. (Twincast)
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three is struck by corruption.
    [Mon Oct 28 09:41:08 2019] You hit Test One Hundred Three for 10638 points of disease damage by Dragonmagic Spell. (Twincast)
    [Mon Oct 28 09:41:08 2019] Test One Hundred Three is struck by dark arcane force!

    Example #2
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 354296 points of fire damage by Ethereal Skyblaze Rk. III. (Critical)
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three's body is consumed in ethereal flames.
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 450 points of cold damage by Freezing Strike VI.
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three shudders.
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 12638 points of fire damage by Blaze of Fire.
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 23479 points of fire damage by Burst of Flames V. (Critical)
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 24549 points of fire damage by Burst of Flames V. (Lucky Critical Twincast)
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:42 2019] You hit Test One Hundred Three for 8770 points of corruption damage by Force of Corruption X. (Critical Twincast)
    [Mon Oct 28 09:41:42 2019] Test One Hundred Three is struck by corruption.
    [Mon Oct 28 09:41:43 2019] You hit Test One Hundred Three for 58935 points of disease damage by Dragonmagic Spell. (Critical Twincast)

    Example #3
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 110711 points of fire damage by Ethereal Skyblaze Rk. III.
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three's body is consumed in ethereal flames.
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 73130 points of fire damage by Blaze of Fire. (Lucky Critical)
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 12638 points of fire damage by Blaze of Fire. (Twincast)
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 9752 points of cold damage by Burst of Ice X. (Lucky Critical Twincast)
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three is struck by ice.
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 4238 points of fire damage by Burst of Flames V. (Twincast)
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:41:50 2019] You hit Test One Hundred Three for 10638 points of disease damage by Dragonmagic Spell. (Twincast)
    [Mon Oct 28 09:41:50 2019] Test One Hundred Three is struck by dark arcane force!

    Example #4
    [Mon Oct 28 09:42:06 2019] You hit Test One Hundred Three for 353863 points of fire damage by Ethereal Skyblaze Rk. III. (Critical)
    [Mon Oct 28 09:42:06 2019] Test One Hundred Three's body is consumed in ethereal flames.
    [Mon Oct 28 09:42:06 2019] You hit Test One Hundred Three for 1688 points of cold damage by Burst of Ice X.
    [Mon Oct 28 09:42:06 2019] Test One Hundred Three is struck by ice.
    [Mon Oct 28 09:42:06 2019] You hit Test One Hundred Three for 9352 points of cold damage by Burst of Ice X. (Critical Twincast)
    [Mon Oct 28 09:42:06 2019] Test One Hundred Three is struck by ice.
    [Mon Oct 28 09:42:06 2019] You hit Test One Hundred Three for 58935 points of disease damage by Dragonmagic Spell. (Critical Twincast)

    Example #5
    [Mon Oct 28 09:42:10 2019] You hit Test One Hundred Three for 132172 points of fire damage by Ethereal Skyfire Rk. III.
    [Mon Oct 28 09:42:10 2019] Test One Hundred Three's body is consumed in ethereal flames.
    [Mon Oct 28 09:42:10 2019] You hit Test One Hundred Three for 4238 points of fire damage by Burst of Flames V.
    [Mon Oct 28 09:42:10 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:42:10 2019] You hit Test One Hundred Three for 23479 points of fire damage by Burst of Flames V. (Critical Twincast)
    [Mon Oct 28 09:42:10 2019] Test One Hundred Three is struck by flames.
    [Mon Oct 28 09:42:10 2019] You hit Test One Hundred Three for 9197 points of corruption damage by Force of Corruption X. (Lucky Critical Twincast)
    [Mon Oct 28 09:42:10 2019] Test One Hundred Three is struck by corruption.
    [Mon Oct 28 09:42:10 2019] You hit Test One Hundred Three for 10638 points of disease damage by Dragonmagic Spell. (Twincast)
    Winnowyl, Beimeith, FubarEQ and 3 others like this.