Cannot Reproduce [Paladin] Holy | Blessed Guardian Effect bug

Discussion in 'Resolved' started by Wulfhere, Sep 27, 2021.

  1. Wulfhere Augur

    I'm concerned that the Holy | Blessed Guardian Effects have a bug in their spdat. Apparently these effects are supposed to trigger on the Block skill. Paladins have the Parry skill, not the block skill. So the spell can never trigger for that reason.

    This means that the defensive benefit is reduced from what it would be if this was corrected to the Parry skill. The effect would proc more often if it was properly checking Parry skill. Given how often this disc fails to keep me alive in current content, I would like it to be fixed.

    [34482] Holy Guardian Effect
    Target: Self
    Resist: Beneficial, Blockable: Yes
    Stacking: Holy Guardian's Shield 1
    Focusable: No
    Casting: 0s
    Duration: 3m (30 ticks) Song, Dispelable: Yes
    Max Hits: 120 Offensive Proc Casts
    4: Cast: Holy Guardian Heal on Skill Use (10000)
    5: Limit Skill: Bash
    6: Add Skill Proc: Holy Guardian Heal with 3200% Rate Mod
    7: Limit Skill: Block
    8: Limit Skill: Riposte
    Text: Your shield gains a holy glow.
    Holy power imbues your shield, allowing you to heal yourself when you block, riposte, or bash for the next 3 minutes.

    [55377] Blessed Guardian Effect
    Target: Self
    Resist: Beneficial, Blockable: Yes
    Stacking: Holy Guardian's Shield 4
    Focusable: No
    Casting: 0s
    Duration: 3m (30 ticks) Song, Dispelable: Yes
    Max Hits: 120 Offensive Proc Casts
    4: Cast: Blessed Guardian Heal on Skill Use (10000)
    5: Limit Skill: Bash
    6: Add Skill Proc: Blessed Guardian Heal with 3200% Rate Mod
    7: Limit Skill: Block
    8: Limit Skill: Riposte
    Text: Your shield gains a holy glow.
    Holy power imbues your shield, allowing you to heal yourself for 6251 hit points when you Bash, Block, or Riposte for the next 3 minutes.

    The skill numbers are:
    Bash = 10
    Block = 11
    Parry = 34
    Riposte = 37

    PS: A bash riposte consumes 2 charges (but heals only once!) - Another bug
  2. Wulfhere Augur

    PS: It looks like the SK variants have the same bug. See Unholy and Cursed Guardian Effects
  3. Wulfhere Augur

    Some test data. As per the spdat, the effect:

    • Triggers on the skill attempt, hit or miss
    • Triggers on a bash attempt 100% of the time, consuming most of the hit counters if you have autoskilll bash enabled
    • Triggers on a riposte attempt sometimes, even a bash riposte
    • The effect casts before the skill attempt resolves
    • The heal effect has a (paladin) class level appropriate value, so it is worn gear focused
    • A bash riposte consumes 2 charges (but heals only once!) - Another bug
    [Mon Sep 27 12:45:29 2021] You begin casting Blessed Guardian Heal III.
    [Mon Sep 27 12:45:29 2021] Your Pendant of Whispers feels alive with power.
    [Mon Sep 27 12:45:29 2021] Holy light heals you.
    [Mon Sep 27 12:45:29 2021] You healed Wulfhere for 0 (23657) hit points by Blessed Guardian Heal III.
    [Mon Sep 27 12:45:29 2021] Combat Dummy Lena tries to punch YOU, but misses! (Riposte)
    [Mon Sep 27 12:45:29 2021] You bash Combat Dummy Lena for 5617 points of damage. (Riposte Strikethrough)

    [Mon Sep 27 12:45:52 2021] You healed Wulfhere for 0 (25256) hit points by Blessed Guardian Heal III.
    [Mon Sep 27 12:45:52 2021] Combat Dummy Lena tries to punch YOU, but YOU block with your shield!
    [Mon Sep 27 12:45:52 2021] You punch Combat Dummy Lena for 671 points of damage. (Riposte Strikethrough)

    [Mon Sep 27 12:46:45 2021] You healed Wulfhere for 0 (23946) hit points by Blessed Guardian Heal III.
    [Mon Sep 27 12:46:45 2021] You bash Combat Dummy Lena for 5527 points of damage.

    [Mon Sep 27 12:59:32 2021] You healed Wulfhere for 0 (56628) hit points by Blessed Guardian Heal III. (Lucky Critical)
    [Mon Sep 27 12:59:32 2021] You try to bash Combat Dummy Lena, but miss!
  4. Wulfhere Augur

    This discipline is under performing because of its bugs.
  5. Spacemonkey555 Augur

    SK/PAL use shield block, not block, and it looks to be working for that.
    Wulfhere likes this.
  6. Wulfhere Augur

    No, I don't think so. I attribute that cast to the riposte punch, not the shield block.

    Shield Block is not a (combat) skill. It's not involved with SPA 428. It's an AA ability without a skill number.
  7. Spacemonkey555 Augur

    Still procs Cursed Guardian (verified in log no bash/riposte involved), so if anything is bugged it's the paladin versions.
  8. Wulfhere Augur

    Please provide log of that (shield block proc) happening :)
  9. Spacemonkey555 Augur

    [Tue Mar 01 22:23:27 2022] Your Waning Crescent Soulrender Helm feels alive with power.
    [Tue Mar 01 22:23:27 2022] You hit Shei Vinitras for 45787 points of magic damage by Corrupted Guardian Lifetap. (Lucky Critical)
    [Tue Mar 01 22:23:27 2022] Shei Vinitras is drained by unholy light.
    [Tue Mar 01 22:23:27 2022] You healed Ashiko for 99115 hit points by Corrupted Guardian Lifetap. (Critical)
    [Tue Mar 01 22:23:27 2022] Shei Vinitras tries to hit YOU, but YOU block with your shield! (Flurry)
    [Tue Mar 01 22:23:27 2022] Shei Vinitras tries to kick YOU, but misses! (Flurry)
    [Tue Mar 01 22:23:27 2022] You are protected by a blessed rune.
    ...
    [Sun Feb 27 05:45:41 2022] Your Waning Crescent Soulrender Helm feels alive with power.
    [Sun Feb 27 05:45:41 2022] You hit Shei Vinitras for 50211 points of magic damage by Corrupted Guardian Lifetap. (Critical)
    [Sun Feb 27 05:45:41 2022] Shei Vinitras is drained by unholy light.
    [Sun Feb 27 05:45:41 2022] Shei Vinitras is pierced by YOUR thorns for 15224 points of non-melee damage.
    [Sun Feb 27 05:45:41 2022] Shei Vinitras was chilled to the bone for 11000 points of non-melee damage.
    [Sun Feb 27 05:45:41 2022] Shei Vinitras hits YOU for 29733 points of damage. (Strikethrough)
    [Sun Feb 27 05:45:41 2022] Shei Vinitras tries to hit YOU, but YOU block with your shield!
    [Sun Feb 27 05:45:41 2022] Shei Vinitras is pierced by YOUR thorns for 15224 points of non-melee damage.
    [Sun Feb 27 05:45:41 2022] Shei Vinitras was chilled to the bone for 11000 points of non-melee damage.
    [Sun Feb 27 05:45:41 2022] Shei Vinitras hits YOU for 49553 points of damage. (Strikethrough)
    [Sun Feb 27 05:45:41 2022] Shei Vinitras is distracted.
    ...
    [Sun Feb 27 22:27:33 2022] Your Waning Crescent Soulrender Helm feels alive with power.
    [Sun Feb 27 22:27:33 2022] You hit Shei Vinitras for 43817 points of magic damage by Corrupted Guardian Lifetap. (Critical)
    [Sun Feb 27 22:27:33 2022] Shei Vinitras is drained by unholy light.
    [Sun Feb 27 22:27:33 2022] You healed Ashiko for 9822 (50303) hit points by Corrupted Guardian Lifetap.
    [Sun Feb 27 22:27:33 2022] Shei Vinitras is pierced by YOUR thorns for 21155 points of non-melee damage.
    [Sun Feb 27 22:27:33 2022] Shei Vinitras hits YOU for 1518 points of damage. (Strikethrough)
    [Sun Feb 27 22:27:33 2022] Shei Vinitras tries to hit YOU, but YOU block with your shield!
    [Sun Feb 27 22:27:33 2022] Shei Vinitras is pierced by YOUR thorns for 21155 points of non-melee damage.
    [Sun Feb 27 22:27:33 2022] Shei Vinitras hits YOU for 2008 points of damage. (Strikethrough)
    Wulfhere likes this.
  10. Wulfhere Augur

    Thanks for adding more parse data. Surprising but okay.

    Assuming that's true for paladin as well (SPDAT is the same), then it's just unfortunate that shield block rates have steadily dropped into the single digit 1% because of the priority of combat checks and heroic mods. It would still be better, given the intensity of modern combat, for it to work on the 2nd priority Parry skill check instead.

    That still leaves the remaining bug that I watched happened repeatably vs a combat dummy:

    A bash riposte consumes 2 charges (but heals only once!). This is similar to the Hand of Tunare counter problem that Dzarn fixed in 2019 I believe.
    Spacemonkey555 likes this.
  11. Wulfhere Augur

    Let's assume that HDex gearing is shifting most of the heal proc towards riposte. Let's further assume that knights should favor HDex in order to increase the number of heal procs, in proportion to the increase in riposte rate.

    Here's a no riposte (no-dmg primary), no bash parse vs a single mob showing 21 heal procs for the duration. This is meant to measure passive proc rates from these spdat lines:

    Slot 6: Add Skill Proc: Revered Guardian Heal III with 3200% Rate Mod
    Slot 7: Limit Skill: Block
    Slot 8: Limit Skill: Riposte

    /GU -vs- A cold ghoul - Spells Cast By: Wulfhere: 25 | Bulwark of the Reptile Curse: 0 | Drunken Wandering: 1 | Preservation of the Grotto Rk. III: 1 | Protest for Honor Rk. III: 1 | Revered Guardian Heal III: 21 | Stormwall Stance Rk. III: 1


    There is some strangeness in the logs:
    • Mob strikethrough is masking the cause of most (18/21) of the heal procs
      • Striking through parry, dodge, and shield block only, since riposte is disabled
        • None of these skills are in the spdat, strictly speaking
      • 21/201 (10.4%) of mob swings generated a proc from the 3200% rate mod spdat
        • This is not enough to keep either knight class alive, so you want to be bashing
    • It appears that the dodge skill can proc a heal, even though it's not in the spdat (2/21)
      • 2/21 successful dodges caused a proc
    • It appears that the parry skill can proc a heal, even though it's not in the spdat (1/21)
      • 1/14 successful parries caused a proc
    • HAgi may increase proc chances since parry and dodge are involved
    [Sat Mar 12 10:20:24 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:20:24 2022] A cold ghoul hits YOU for 4844 points of damage. (Strikethrough)

    [Sat Mar 12 10:20:26 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:20:26 2022] A cold ghoul bashes YOU for 4008 points of damage. (Strikethrough)

    [Sat Mar 12 10:20:37 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:20:37 2022] A cold ghoul hits YOU for 20653 points of damage. (Strikethrough)

    [Sat Mar 12 10:20:43 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:20:43 2022] A cold ghoul tries to hit YOU, but YOU dodge!

    [Sat Mar 12 10:20:54 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:20:54 2022] A cold ghoul tries to hit YOU, but YOU dodge!

    [Sat Mar 12 10:21:44 2022] You begin casting Revered Guardian Heal III.
    [Sat Mar 12 10:21:44 2022] A cold ghoul tries to hit YOU, but YOU parry!
    Fenthen likes this.
  12. Ratalthor Developer

    We gave this a try with a Paladin and found that both Parry and Shield Block do proc the effect. Whether or not it ends up being useful has been surfaced to the team as feedback. Thanks!
    Wulfhere and Nennius like this.