Fixed Internally Advanced Loot Window - Link All Items

Discussion in 'Resolved' started by Rand al`Thor, Jan 20, 2022.

  1. Rand al`Thor New Member

    There is a feature in the advanced loot window where you right click on the corpse name and it pops up a context menu with an option to link all items.

    When there are too many items to link on a single line it creates a second overflow line with the remaining links.

    This feature seems to have been broken in the latest patch for the second overflow line - it has been adding another erroneous item link at the end of the line.

    DKP tools which use this feature rely on accurate number of links with the vertical bar deliminators to correctly parse the loot in the log files.

    All raid events failed for us tonight for any boss with enough loot to overflow to second line links. Specifically, it was failing in all the Omens of War MPG Raid Trials where there are five boss loot items in each event (three pieces of gear and two spell/ability runes).
    Rondor likes this.
  2. Axxius Augur

    Another related bug with the Link All overflow: if the length of the line after the last item link on that line is greater than 160 characters, then the separator (" | " ) is not added at all, even though there are more item links going to the next line.
  3. klanderso Developer

    I was looking at a different advanced loot window bug and it looks like it's linked to this one! Should be fixed for the next update :)
    Rondor, Yinla, Axxius and 3 others like this.
  4. Rand al`Thor New Member

    This is not fixed, can this be re-opened or should I re-post?
    Rondor likes this.
  5. Rand al`Thor New Member

    Specifically, not fixed in the update this week - was still creating bad link messages on raid last night.

    I didn’t test single line messages, but all multi line messages with ~4+ loot links were adding extra links
    Rondor likes this.
  6. Ratalthor Developer

    Is this issue still happening for anyone as of the April update?
  7. Imukai Augur

    Found a mob in Twilight with 8 items.

    It put 4 on one line with a pipe at the end, auto-sent that line. It created a 2nd line with 4 items on it, no pipe at the end, auto-sent that line. It created a 3rd line with 1 item on it (a duplicate of the 8th item) in my chat input window ready to be sent.

    It always seems to want to duplicate the final item.

    If a mob only has 1 item, doing Link All will produce a duplicate (no pipe in between).

    Did QA test it?
  8. Axxius Augur

    Yes.
    Code:
    [Sun May 01 20:44:47 2022] Nilweanx tells the guild, 'Bite of the Vampire | Bite of the Vampire | Faded Waning Gibbous Chest Armor | Faded Waning Gibbous Chest Armor | '
    [Sun May 01 20:44:47 2022] Nilweanx tells the guild, 'Dual Partisan of the Shattered Vow | Greater Shadowscribed Parchment | Glowing Shadowscribed Parchment | Median Shadowscribed Parchment'
    [Sun May 01 20:44:47 2022] Nilweanx tells the guild, 'Minor Shadowscribed Parchment | Minor Shadowscribed Parchment | Calcified Bloodied Ore'
    To be precise, how this happens: the Master Looter types "/gu " and then clicks Link All. The client then forms the text/link lines and splits them with the max chat buffer in mind. But it doesn't seem to take that "/gu " into account. It should reduce the max allowed line length by what's already in the input box (in this case by 4).